[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811330#comment-16811330
]
Gilles commented on GEOMETRY-29:
--------------------------------
{quote}what do you think?
{quote}
I'd assume that if you wonder, it is better, at this point, to say "no" to both.
It's of course good to leave a note (code comment) and revisit later.
> Plane API cleanup
> -----------------
>
> Key: GEOMETRY-29
> URL: https://issues.apache.org/jira/browse/GEOMETRY-29
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
>
> The following changes should be made to the
> {{o.a.c.g.euclidean.threed.Plane}} class:
> * make the class immutable
> * use well-named factory methods instead of constructor overloads
> * provide a factory method to create a plane with user-supplied {{u}} and
> {{v}} axes. The current implementation allows the normal to be provided but
> chooses its own planar axes (see {{setFrame}}).
> * add {{equals}}, {{hashCode}}, and {{toString}} methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
