[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813961#comment-16813961
]
Matt Juntunen commented on GEOMETRY-29:
---------------------------------------
Sounds good. [~rathgeber], could you make those last changes?
- make {{origin}} computed instead of stored
- make {{areCoplanar}} a private helper method in {{Plane}} (The reasoning
behind this is to try to keep the public API small and maintainable as a
general rule and only add methods if required. It's easier by far to add things
later than to remove them.)
[~erans], is there anything that might prevent you from merging this after the
above items are complete?
> Plane API cleanup
> -----------------
>
> Key: GEOMETRY-29
> URL: https://issues.apache.org/jira/browse/GEOMETRY-29
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
>
> The following changes should be made to the
> {{o.a.c.g.euclidean.threed.Plane}} class:
> * make the class immutable
> * use well-named factory methods instead of constructor overloads
> * provide a factory method to create a plane with user-supplied {{u}} and
> {{v}} axes. The current implementation allows the normal to be provided but
> chooses its own planar axes (see {{setFrame}}).
> * add {{equals}}, {{hashCode}}, and {{toString}} methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
