[
https://issues.apache.org/jira/browse/COMPRESS-485?focusedWorklogId=240689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240689
]
ASF GitHub Bot logged work on COMPRESS-485:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/19 22:59
Start Date: 11/May/19 22:59
Worklog Time Spent: 10m
Work Description: Tibor17 commented on pull request #79: Pull/78
COMPRESS-485 + Substituting 'synchronized' with faster and fully thread-safe
collections 'ConcurrentLinkedDeque' and iterators.
URL: https://github.com/apache/commons-compress/pull/79
One `ArrayList` was synchronized and another was not.
In this concurrent access. Considering wekanesses of memory model this may
produce sporadic NPE (so that retrieved Future may not be visible in another
thread)
Using synchronization would avoid it but why to use it in such simple
critical sections today if we have concurrent collections in Java 1.5+.
So used `ConcurrentLinkedDequeue` and that's it. Easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 240689)
Time Spent: 1h 40m (was: 1.5h)
> Reproducible Builds: keep entries order when gathering ScatterZipOutputStream
> content in ParallelScatterZipCreator
> ------------------------------------------------------------------------------------------------------------------
>
> Key: COMPRESS-485
> URL: https://issues.apache.org/jira/browse/COMPRESS-485
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.18
> Reporter: Hervé Boutemy
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> currently, zip files created using ParallelScatterZipCreator have random
> order.
> This is causing issues when trying to do Reproducible Builds with Maven
> MNG-6276
> Studying ParallelScatterZipCreator, entries are kept sorted in memory in
> futures list: instead of writing each full scatter in sequence, iterating
> over futures should permit to write each zip entry in original order, without
> changing the API or any performance of the gathering process
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
