garydgregory commented on a change in pull request #14: [BEANUTILS-515] Java8 Time converters URL: https://github.com/apache/commons-beanutils/pull/14#discussion_r338320192
########## File path: src/test/java/org/apache/commons/beanutils2/converters/LocalTimeConverterTestCase.java ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.commons.beanutils2.converters; + + +import java.time.LocalTime; + +import org.apache.commons.beanutils2.ConversionException; +import org.apache.commons.beanutils2.Converter; + +import junit.framework.TestCase; +import junit.framework.TestSuite; + + +/** + * Test Case for the LocalTimeConverter class. + * + */ +public class LocalTimeConverterTestCase extends TestCase { + + public static TestSuite suite() { + return new TestSuite(LocalTimeConverterTestCase.class); + } + + // ------------------------------------------------------------------------ + + private Converter converter = null; + + // ------------------------------------------------------------------------ + + public LocalTimeConverterTestCase(final String name) { + super(name); + } + + protected Class<?> getExpectedType() { + return LocalTime.class; + } + + protected Converter makeConverter() { + return new LocalTimeConverter(); + } + + // ------------------------------------------------------------------------ + + @Override + public void setUp() throws Exception { + converter = makeConverter(); + } + + @Override + public void tearDown() throws Exception { + converter = null; + } + + // ------------------------------------------------------------------------ + + public void testSimpleConversion() throws Exception { + final String[] message= { + "from String", + "from String", + "from String", + "from String", + "from String", + "from String", + "from String", + "from String", + }; + + final Object[] input = { + "10:15", + "08:45:30" + }; + + final LocalTime[] expected = { + LocalTime.parse("10:15"), + LocalTime.parse("08:45:30") + }; + + for(int i=0;i<expected.length;i++) { + assertEquals(message[i] + " to URI",expected[i],converter.convert(LocalTime.class,input[i])); + assertEquals(message[i] + " to null type",expected[i],converter.convert(null,input[i])); + } + + for(int i=0;i<expected.length;i++) { + assertEquals(input[i] + " to String", input[i], converter.convert(String.class, expected[i])); + } + } + + /** + * Tests a conversion to an unsupported type. + */ + public void testUnsupportedType() { + try { + converter.convert(Integer.class, "http://www.apache.org";); + fail("Unsupported type could be converted!"); Review comment: A huge task for later: JUnit 5. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
