garydgregory commented on a change in pull request #14: [BEANUTILS-515] Java8 Time converters URL: https://github.com/apache/commons-beanutils/pull/14#discussion_r338319693
########## File path: src/main/java/org/apache/commons/beanutils2/converters/ZoneOffsetConverter.java ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.beanutils2.converters; + +import java.time.ZoneOffset; + +/** + * {@link org.apache.commons.beanutils2.Converter} implementation that handles conversion + * to and from <b>java.time.ZoneOffset</b> objects. + * <p> + * Can be configured to either return a <i>default value</i> or throw a + * <code>ConversionException</code> if a conversion error occurs. + * Review comment: - I think it would be nice if each converter class has a `@see` in the class Javadoc to its underlying JRE class. - The tag `<p>` and all HTML tags should be closed to avoid headaches on later Java versions. - It would be nicer to use Javadoc own `{@code foo}` instead of the HTML `<code>foo</code>`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
