[
https://issues.apache.org/jira/browse/COMPRESS-342?focusedWorklogId=339772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339772
]
ASF GitHub Bot logged work on COMPRESS-342:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 06:31
Start Date: 07/Nov/19 06:31
Worklog Time Spent: 10m
Work Description: PeterAlfreadLee commented on issue #83: COMPRESS-342
random access of 7z files
URL: https://github.com/apache/commons-compress/pull/83#issuecomment-550886814
> The latest change may only be necessary when the content methods of `file`
actually is `null`, which may not be the case when jumping backwards to a
position that has already been reached by other means. But an additional check
would mainly be an optimization.
I agree. I will add the non-null check for the content methods, and the
content methods will not be set when the content methods is not null.
> Right now I'm not sure the code works in situations where we jump
backwards inside the folder or whether we'd need to remove streams from
`deferredBlockStreams` otherwise. Probably I'd need to write a test for that :-)
I agree. I forgot the situations that we may jump backwards inside the
folder. It seems I can only reopen the folder and skip the previous files again.
I will modify both of these 2 and push my code today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339772)
Time Spent: 2h (was: 1h 50m)
> random access of 7z files
> -------------------------
>
> Key: COMPRESS-342
> URL: https://issues.apache.org/jira/browse/COMPRESS-342
> Project: Commons Compress
> Issue Type: Sub-task
> Components: Archivers
> Reporter: Stefan Bodewig
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
