[ 
https://issues.apache.org/jira/browse/COMPRESS-342?focusedWorklogId=339998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339998
 ]

ASF GitHub Bot logged work on COMPRESS-342:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/19 15:50
            Start Date: 07/Nov/19 15:50
    Worklog Time Spent: 10m 
      Work Description: bodewig commented on pull request #83: COMPRESS-342 
random access of 7z files
URL: https://github.com/apache/commons-compress/pull/83#discussion_r341814563
 
 

 ##########
 File path: 
src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
 ##########
 @@ -1208,6 +1208,42 @@ private InputStream getCurrentStream() throws 
IOException {
         return deferredBlockStreams.get(0);
     }
 
+    public InputStream getInputStream(SevenZArchiveEntry entry) throws 
IOException {
 
 Review comment:
   Please add javadoc for the new method. Probably stating it may perform bad.
   
   Also I think it will break the current approach of accessing entries in 
sequence as the "in sequence" code relies on the file position. Unless I'm 
wrong we need a big warning here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 339998)
    Time Spent: 2.5h  (was: 2h 20m)

> random access of 7z files
> -------------------------
>
>                 Key: COMPRESS-342
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-342
>             Project: Commons Compress
>          Issue Type: Sub-task
>          Components: Archivers
>            Reporter: Stefan Bodewig
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to