aherbert commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-554766774 In your PR it looks like the `start` and `add` methods of `IncrementalHash32` and `IncrementalHash32_x86` are exactly the same. So just deprecate `end` in favour of a new method `hash32x86`. You can still use the class to generate the old flawed hash but now have a new finalisation method to compute the correct hash. No need to duplicate the entire class just to change one method.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
