aherbert commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-555615501 Hi @yonik, The code for the UTF-8 hash is nice. But I do not think it should be part of this PR. This PR is specifically trying to fix the current broken implementation of MurmurHash3 for `byte[]` due to some sign extension bugs. It should be simple but it turning into an epic. I found a bug in your code where it does not support the correct interpretation of illegal characters which should be represented as an invalid byte sequence. See the example above trying to encode `String.valueOf('\uD801');` I think the UTF-8 encoding should be part of another PR and ideally fix the support for invalid characters.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
