bodewig commented on a change in pull request #84: COMPRESS-477 Add support for
extracting splitted zip files
URL: https://github.com/apache/commons-compress/pull/84#discussion_r341815590
##########
File path:
src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
##########
@@ -367,13 +367,9 @@ public ZipArchiveEntry getNextZipEntry() throws
IOException {
private void readFirstLocalFileHeader(final byte[] lfh) throws IOException
{
readFully(lfh);
final ZipLong sig = new ZipLong(lfh);
- if (sig.equals(ZipLong.DD_SIG)) {
Review comment:
I think I'd prefer to make this conditional on an explicit flag passed in
the constructor so people who do not expect split archives won't see incomplete
archives without any indication of the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
