bodewig commented on a change in pull request #84: COMPRESS-477 Add support for
extracting splitted zip files
URL: https://github.com/apache/commons-compress/pull/84#discussion_r341816060
##########
File path:
src/main/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannel.java
##########
@@ -44,9 +44,9 @@
*/
public class MultiReadOnlySeekableByteChannel implements SeekableByteChannel {
- private final List<SeekableByteChannel> channels;
- private long globalPosition;
- private int currentChannelIdx;
+ protected final List<SeekableByteChannel> channels;
Review comment:
I'd prefer if you added protected methods accessing the fields rather than
making the fields protected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
