kinow commented on a change in pull request #5: Proposal for a patch for
Imaging-159 using a POJO
URL: https://github.com/apache/commons-imaging/pull/5#discussion_r370989811
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/TiffReader.java
##########
@@ -309,11 +309,13 @@ public Collector() {
this(null);
}
- public Collector(final Map<String, Object> params) {
+ public Collector(final ImagingParameters params) {
boolean tmpReadThumbnails = true;
- if (params != null &&
params.containsKey(ImagingConstants.PARAM_KEY_READ_THUMBNAILS)) {
- tmpReadThumbnails = Boolean.TRUE.equals(params
- .get(ImagingConstants.PARAM_KEY_READ_THUMBNAILS));
+ if (params != null) {
+ if (params instanceof ImagingParametersTiff) {
Review comment:
`if` statement can be combined I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
