kinow commented on a change in pull request #5: Proposal for a patch for
Imaging-159 using a POJO
URL: https://github.com/apache/commons-imaging/pull/5#discussion_r370989954
##########
File path:
src/main/java/org/apache/commons/imaging/formats/pnm/PnmImageParser.java
##########
@@ -334,6 +325,12 @@ public void writeImage(final BufferedImage src, final
OutputStream os, Map<Strin
writer = new PamWriter();
}
}
+
+ // read parameters specific for the PNM format
+ if (params instanceof ImagingParametersPnm) {
Review comment:
Would be nice if we could use generics, instead of checking instance types.
The parameters of `PnmImageParser` must definitely be an `ImagingParametersPnm`
I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
