[jira] [Commented] (LANG-1499) Equals transitivity is violated in EqualsBuilder

[Sebb (Jira)]

    [ 
https://issues.apache.org/jira/browse/LANG-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023822#comment-17023822
 ] 

Sebb commented on LANG-1499:
----------------------------

The code for EqualsBuilder.reflectionEquals() does not check whether the 
classes are the same:

http://commons.apache.org/proper/commons-lang/xref/org/apache/commons/lang3/builder/EqualsBuilder.html#L452

However the class Javadoc says it should:
http://commons.apache.org/proper/commons-lang/xref/org/apache/commons/lang3/builder/EqualsBuilder.html#L56

There is a disconnect here, which could be the cause of the lack of 
transitivity.

I think this issue needs some more analysis before any fixes can be identified.

> Equals transitivity is violated in EqualsBuilder
> ------------------------------------------------
>
>                 Key: LANG-1499
>                 URL: https://issues.apache.org/jira/browse/LANG-1499
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.builder.*
>    Affects Versions: 3.9
>         Environment: Ubuntu 18.04
> JDK 1.8.0_221
> Commons Lang 3.9-RC2
> JUnit 5.4
>            Reporter: Zhiqiang Zang
>            Priority: Major
>              Labels: Equals(), EqualsBuilder, transitivity
>         Attachments: EqualsTransitivityTest.java
>
>
> EqualsBuilder.reflectionEquals() does not hold transitivity when comparing 
> two subclasses extending a common superclass. For example:
> Given that both class D and E are subclasses of class C, C == D and C == E 
> should imply D == E. However EqualsBuilder.reflectionEquals(D, E) returns 
> *false* when both EqualsBuilder.reflectionEquals(C, D) and 
> EqualsBuilder.reflectionEquals(C, E) return true.
> A junit test is provided as attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)