[
https://issues.apache.org/jira/browse/LANG-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023818#comment-17023818
]
Sebb commented on LANG-1499:
----------------------------
The test seems invalid to me.
Given that the equals() method of the C class returns false unless the the two
classes are identical, it seems to me that an instance of C should never equal
an instance of D or an instance of E; likewise an instance of D can never equal
an instance of E.
Whilst I agree that the result of equals() should be transitive, that depends
on the correctness of the other equalities.
If there is a bug here, it seems to me that instances of C and D should not be
considered equal.
> Equals transitivity is violated in EqualsBuilder
> ------------------------------------------------
>
> Key: LANG-1499
> URL: https://issues.apache.org/jira/browse/LANG-1499
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.builder.*
> Affects Versions: 3.9
> Environment: Ubuntu 18.04
> JDK 1.8.0_221
> Commons Lang 3.9-RC2
> JUnit 5.4
> Reporter: Zhiqiang Zang
> Priority: Major
> Labels: Equals(), EqualsBuilder, transitivity
> Attachments: EqualsTransitivityTest.java
>
>
> EqualsBuilder.reflectionEquals() does not hold transitivity when comparing
> two subclasses extending a common superclass. For example:
> Given that both class D and E are subclasses of class C, C == D and C == E
> should imply D == E. However EqualsBuilder.reflectionEquals(D, E) returns
> *false* when both EqualsBuilder.reflectionEquals(C, D) andÂ
> EqualsBuilder.reflectionEquals(C, E) return true.
> A junit test is provided as attachment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
