brettlounsbury commented on a change in pull request #101: IO-649 - Improve the
performance of the contentEquals() methods.
URL: https://github.com/apache/commons-io/pull/101#discussion_r371269571
##########
File path: src/main/java/org/apache/commons/io/IOUtils.java
##########
@@ -691,80 +692,173 @@ public static void closeQuietly(final Writer output) {
}
/**
- * Compares the contents of two Streams to determine if they are equal or
- * not.
+ * Compares the contents of two Streams to determine if they are equal or
not.
* <p>
- * This method buffers the input internally using
- * <code>BufferedInputStream</code> if they are not already buffered.
- * </p>
+ * This method buffers the input internally using {@link
#DEFAULT_BUFFER_SIZE} sized buffers.
*
* @param input1 the first stream
* @param input2 the second stream
* @return true if the content of the streams are equal or they both don't
* exist, false otherwise
- * @throws NullPointerException if either input is null
* @throws IOException if an I/O error occurs
*/
@SuppressWarnings("resource")
public static boolean contentEquals(final InputStream input1, final
InputStream input2)
throws IOException {
+ return contentEquals(input1, input2, DEFAULT_BUFFER_SIZE);
+ }
+
+ /**
+ * Compares the contents of two Streams to determine if they are equal or
not.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
