brettlounsbury commented on issue #101: IO-649 - Improve the performance of the contentEquals() methods. URL: https://github.com/apache/commons-io/pull/101#issuecomment-578802448 @garydgregory, I really appreciate your thorough review of my code. I think at this point I have addressed your comments, but if you have any others please let me know. I will add that I made the IOUtils.DEFAULT_BUFFER_SIZE constant package private (default visibility) so it could be referenced from IOUtils tests so that I can ensure the logic makes sense around buffer boundaries and I didn't want to clone that property since it could later be mutated and invalidate some of the edge condition testing being done.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
