[
https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087057#comment-17087057
]
Matt Juntunen commented on GEOMETRY-92:
---------------------------------------
I'm not seeing a benefit from having the ray and segment classes as nested
classes. Locating the correct "tools", i.e. implementations of
{{ConvexSubLine}} can be done easily by looking at the javadocs, regardless of
whether the classes are nested or not. Lumping everything together under
{{Line}} will make that class bloated and does improve readability, IMO (I
actually think it reduces it).
{quote}What are its use-cases? [TerminatedLine/ReverseRay]
{quote}
The end-point-only half-line class needs to exist in order to cover all
possible sublines. I don't think that many users will be creating them
directly, but they will naturally occur during use. For example, splitting a
{{Line.Span}} instance at a point produces a {{Ray}} and a
{{TerminatedLine/ReverseRay}}. It can also be produced by reversing a {{Ray}}.
> Segment is not mathematically correct
> -------------------------------------
>
> Key: GEOMETRY-92
> URL: https://issues.apache.org/jira/browse/GEOMETRY-92
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{Segment}} class is not mathematically correct because line segments are
> defined as having distinct start and end points, whereas the start and end
> points in {{Segment}} are optional. In other words, an instance of
> {{Segment}} can represent an entire line, a ray, or a segment. I propose
> renaming the existing {{Segment}} class to {{ConvexSubLine}} and creating
> subclasses to represent the distinct types of sublines.
> * {{ConvexSubLine}} - Abstract convex subline class. The factory methods
> (such as fromPoints()), would examine the inputs and return one of the
> specific subclasses below. Each subclass would also contain its own factory
> methods that apply input validation (eg, no null points when creating a
> {{Segment}}). This would also allow each subclass to optimize some
> computations based on the known characteristics of the represented entity.
> ** {{FullLine}} - no start or end points
> ** {{Segment}} - contains non-null start point and end point
> ** {{Ray}} - contains non-null start point and null end point
> ** {{ReverseRay}} - contains non-null end point and null start point (not
> sure if there is a more mathematical term for this)
> These changes would also apply to the 3D classes:
> * {{ConvexSubLine3D}}
> ** {{FullLine3D}}
> ** {{Segment3D}}
> ** {{Ray3D}}
> ** {{ReverseRay3D}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
