gwlucastrig commented on pull request #72: URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-625762025
I had no idea the pom.xml changed. Netbeans is a pain. What a stupid feature! I will put it back tonight. On Fri, May 8, 2020, 6:49 AM Bruno P. Kinoshita <[email protected]> wrote: > *@kinow* commented on this pull request. > ------------------------------ > > In pom.xml > <https://github.com/apache/commons-imaging/pull/72#discussion_r422074883>: > > > + <artifactId>selenium-java</artifactId> > + <scope>test</scope> > + <version>2.44.0</version> > + </dependency> > + <dependency> > + <groupId>com.opera</groupId> > + <artifactId>operadriver</artifactId> > + <scope>test</scope> > + <version>1.5</version> > + <exclusions> > + <exclusion> > + <groupId>org.seleniumhq.selenium</groupId> > + <artifactId>selenium-remote-driver</artifactId> > + </exclusion> > + </exclusions> > + </dependency> > > @gwlucastrig <https://github.com/gwlucastrig> what tests are using > Selenium? > ------------------------------ > > In > src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java > <https://github.com/apache/commons-imaging/pull/72#discussion_r422076450>: > > > @@ -166,7 +166,7 @@ private void interpretStrip( > // this logic will handle all cases not conforming to the > // special case handled above > > - try (final BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) { > + try (BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) { > > The less differences in the pull request that are not directly related, > the easier it is to review the changes IMO. But if you changed only one or > two places that should be fine, otherwise it's better to send the PMD > changes in another PR. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-imaging/pull/72#pullrequestreview-408154953>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEWJDYKC67GLF2JCSZJNOXTRQPPSFANCNFSM4MAWGVRQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
