kinow commented on a change in pull request #78:
URL: https://github.com/apache/commons-imaging/pull/78#discussion_r432139332



##########
File path: 
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderTiled.java
##########
@@ -125,8 +125,8 @@ private void interpretTile(final ImageBuilder imageBuilder, 
final byte[] bytes,
         // verify that all samples are one byte in size
         final boolean allSamplesAreOneByte = isHomogenous(8);
 
-        if (predictor != 2 && bitsPerPixel == 24 && allSamplesAreOneByte) {
-            int k = 0;
+          if (bitsPerPixel == 24 && allSamplesAreOneByte

Review comment:
       I think this `if` is not aligned with the `final` statement above. 
Haven't looked at the code in the IDE, but maybe it is formatted with wrong 
number of spaces?

##########
File path: 
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
##########
@@ -144,7 +144,7 @@ private void interpretStrip(
         // verify that all samples are one byte in size
         final boolean allSamplesAreOneByte = isHomogenous(8);
 
-        if (predictor != 2 && bitsPerPixel == 8 && allSamplesAreOneByte) {
+         if (predictor != 2 && bitsPerPixel == 8 && allSamplesAreOneByte) {

Review comment:
       Misaligned with the lines above?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to