kinow commented on pull request #78: URL: https://github.com/apache/commons-imaging/pull/78#issuecomment-635920302
> Do you want me to enter another JIRA item? The performance enhancement does represent a functional change, but I didn't want to start spaming JIRA. > > How do you want me to confirm performance testing? It is more because we are changing the code. Small changes like code style, typos, or adding new and simple/small tests can be added without a JIRA. But for changes in the code it's better to always have an issue associated, so that users/devs can link in discussions in the mailing list for example. >How do you want me to confirm performance testing? Sorry @gwlucastrig I thought you said you were going to measure the performance, but you actually said it was the coverage. :point_down: >I tried to make the changes be as clear as possible to simplify inspection. I will check Trevor later to make sure I managed to improve coverage (or at least not degrade it). The bot has already confirmed that the coverage improved. So once we have the JIRA we are ready to merge this one and include in the changelog for the next release. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
