XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844925
##########
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/IntegerLocaleConverter.java
##########
@@ -215,8 +215,8 @@ public IntegerLocaleConverter(final Object defaultValue,
final Locale locale, fi
protected Object parse(final Object value, final String pattern) throws
ParseException {
final Number parsed = (Number) super.parse(value, pattern);
if (parsed.longValue() != parsed.intValue()) {
- throw new ConversionException("Suplied number is not of type
Integer: " + parsed.longValue());
+ throw new ConversionException("Supplied number is not of type
Integer: " + parsed.longValue());
}
- return Integer.valueOf(parsed.intValue()); // unlike superclass it
will return proper Integer
+ return parsed.intValue(); // unlike superclass it will return proper
Integer
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
