XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432845691
##########
File path: src/main/java/org/apache/commons/beanutils2/MethodUtils.java
##########
@@ -1150,7 +1150,7 @@ private static float getObjectTransformationCost(Class<?>
srcClass, final Class<
*
* @return true if the assignment is compatible.
*/
- public static final boolean isAssignmentCompatible(final Class<?>
parameterType, final Class<?> parameterization) {
+ public static boolean isAssignmentCompatible(final Class<?> parameterType,
final Class<?> parameterization) {
Review comment:
> If you are blindly applying changes your IDE suggests, then that's not
a good thing. There is a difference or the language would not allow it. I think
an internet search will help you understand the difference. Unless there is a
reason to change it, don't.
yep you are right; add a final can stop the function from being hidden by
sub class, and class MethodUtils is not a final class thus it is meaningful to
have final here.
will revert the changes immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
