garydgregory commented on a change in pull request #117:
URL: https://github.com/apache/commons-io/pull/117#discussion_r432845089
##########
File path:
src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestSimple.java
##########
@@ -66,6 +67,10 @@ public void testUnsupportedEncodingBig5() throws
URISyntaxException {
() -> new ReversedLinesFileReader(testFileEncodingBig5,
IOUtils.DEFAULT_BUFFER_SIZE, "Big5").close());
}
-
+ @Test
+ public void testNullEncoding() throws IOException, URISyntaxException {
+ new ReversedLinesFileReader(new
File(this.getClass().getResource("/test-file-empty.bin").toURI()),
+ (Charset) null);
+ }
Review comment:
Hi @mernst,
Thank you for your update to this PR.
The new unit test indeed tests that the ctor does not blow on a null Charset
but it does not test that the default Charset kicks in.
Another update would be great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
