mernst commented on a change in pull request #117:
URL: https://github.com/apache/commons-io/pull/117#discussion_r444441946
##########
File path:
src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestSimple.java
##########
@@ -66,6 +67,10 @@ public void testUnsupportedEncodingBig5() throws
URISyntaxException {
() -> new ReversedLinesFileReader(testFileEncodingBig5,
IOUtils.DEFAULT_BUFFER_SIZE, "Big5").close());
}
-
+ @Test
+ public void testNullEncoding() throws IOException, URISyntaxException {
+ new ReversedLinesFileReader(new
File(this.getClass().getResource("/test-file-empty.bin").toURI()),
+ (Charset) null);
+ }
Review comment:
I agree these tests are useful to improve code coverage. But they are
not directly related to the change, and previous changes to this code were
permitted without adding these missing tests. Could we create a new pull
request or issue to improve the coverage of the test suite, to avoid blocking
this pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
