theobisproject commented on pull request #113:
URL: https://github.com/apache/commons-compress/pull/113#issuecomment-656323828


   > I am wondering if the introduction of utility streams would not best be 
done by depending on Apache Commons IO which already contains a bounded stream 
for example
   
   As I understood commons-compress does purposefully not depend on Commons IO. 
This is something which I cannot decide to change.
   
   > for BoundedSeekableByteChannelInputStream, please tell users if it is 
thread-safe in its javadoc.
   for BoundedNIOInputStream , please tell users if it is thread-safe in its 
javadoc.
   
   I will add the information if the general design is accepted from the 
maintainers.
   
   > for TarArchiveSparseZeroInputStream, maybe this class should be added to 
commons-io instead.
   
   In my opinion this adds no value for Commons IO and should not be used 
outside of the tar implementation. I only moved this class to reuse it in both 
implementations and made it package protected so nobody outside the tar package 
will use it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to