theobisproject commented on pull request #113: URL: https://github.com/apache/commons-compress/pull/113#issuecomment-662962115
I know you are working on this library in your free time. So I did expect this big change to take some time before it is integrated. > IMHO this would be a nice addition even though I don't expect many people to require random access to a raw tar archive. Most people likely deal with tar archives that have been compressed and so you'd need to decompress it to a temporary file (or memory) for random access. As you pointed out this only brings better speed for some special cases e.g. random access or somthing like the `TarLister` where no content is read and therefore the stream needs to read and discard all data. Specifially for compressed archives it can even take longer depending on the target where the file is decompressed to. > have you considered making `TarArchiveEntry` implement `EntryStreamOffsets `? Seems like I missed this interface. Since this exactly what I wanted to implement I will change the implementation to implement the `EntryStreamOffsets` interface. > I'd be in favour of moving stream implementations to the utils package, in particular if you copy code from the zip package The code I moved out of the `ZipFile` class is already located in the utils package. Only the Tar specific streams I didn't create in the utils package because in my opinion nobody outside the library should access them and currently no other archive needs similar streams. > nitpicking: the methods you've moved to `TarUtils` probably don't need to be public. I agree and will change the code which was moved to the `TarUtils` to be not public. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
