[
https://issues.apache.org/jira/browse/IO-676?focusedWorklogId=459844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459844
]
ASF GitHub Bot logged work on IO-676:
-------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/20 14:55
Start Date: 16/Jul/20 14:55
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #124:
URL: https://github.com/apache/commons-io/pull/124#discussion_r455849949
##########
File path: src/test/java/org/apache/commons/io/FileUtilsTestCase.java
##########
@@ -1015,6 +1021,12 @@ public void testIsFileNewerOlder() throws Exception {
final Date date = new Date();
Review comment:
In general, you want to use hard coded dates in tests in order to avoid
tests failing on the two times a year the build runs in a locale that happens
to perform a daylight-saving-time switch. Yes, I've actually seen this happen
(at work.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459844)
Time Spent: 2h 50m (was: 2h 40m)
> Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time
> API.
> ----------------------------------------------------------------------------------
>
> Key: IO-676
> URL: https://issues.apache.org/jira/browse/IO-676
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
> Reporter: Isira Seneviratne
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
