psteitz commented on a change in pull request #32:
URL: https://github.com/apache/commons-pool/pull/32#discussion_r456990057
##########
File path: src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
##########
@@ -46,6 +51,9 @@
/** Executor instance */
private static ScheduledThreadPoolExecutor executor;
//@GuardedBy("EvictionTimer.class")
+ /** Keys are weak references to tasks, values are runners managed by
executor. */
+ private static final HashMap<WeakReference<Runnable>, WeakRunner> taskMap
= new HashMap<>(); // @GuardedBy("EvictionTimer.class")
Review comment:
No, access is only inside sync blocks. (see GuardedBy annotation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
