garydgregory commented on a change in pull request #32:
URL: https://github.com/apache/commons-pool/pull/32#discussion_r458217308
##########
File path:
src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
##########
@@ -783,12 +783,21 @@ final void assertOpen() throws IllegalStateException {
*/
final void startEvictor(final long delay) {
Review comment:
Not specific to this PR, but IMO this name needs a scale postfix, like
`delayMillis`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
