[ 
https://issues.apache.org/jira/browse/MATH-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160871#comment-17160871
 ] 

Mohammad Rezaei commented on MATH-1550:
---------------------------------------

{{I think you mean the class SimplexTableau (not Solver).}}

{{If that is correct, I'm not sure I understand what you mean by marking more 
fields final. The core data structures are mutable and if I'm looking at the 
code right, they are meant to be that way.}}

> SimplexTableau (linear programming)
> -----------------------------------
>
>                 Key: MATH-1550
>                 URL: https://issues.apache.org/jira/browse/MATH-1550
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.6.1
>            Reporter: Gilles Sadowski
>            Priority: Minor
>              Labels: design
>             Fix For: 4.0, 4.X
>
>
> Class {{SimplexSolver}} is package private and does not seem designed for 
> inheritance, but it contains "protected" methods.
> There are several instance fields that should preferably be made "final" (for 
> thread safety).  It seems that to do this, some design changes are necessary 
> (a.o. the relationship with {{SimplexSolver}} should be clarified).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to