[
https://issues.apache.org/jira/browse/MATH-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161617#comment-17161617
]
Gilles Sadowski commented on MATH-1550:
---------------------------------------
{quote}For this class, none of this matters because it's not a public class and
it's only ever instantiated in a method
{quote}
Perhaps you could clarify the documentation in another PR (?).
{quote}[...] how sparse the testing for SimplexSolver is. [...] first implement
[...] tests for both correctness and performance.
{quote}
Sure; more tests are welcome.
{quote}if you really want to explore making the matrix immutable
{quote}
*Me* not really. ;)
We are looking for knowledgeable people to help maintain the various areas of
this large project. Several chunks have already been extracted from "Commons
Math" into more manageable (more focused) components:
* [Commons RNG|https://commons.apache.org/proper/commons-rng/]
* [Commons Numbers|https://commons.apache.org/proper/commons-numbers/]
* [Commons Geometry|https://commons.apache.org/proper/commons-geometry/]
For all of them, the move entailed many improvements, including enhanced
performance and higher test coverage.
> SimplexTableau (linear programming)
> -----------------------------------
>
> Key: MATH-1550
> URL: https://issues.apache.org/jira/browse/MATH-1550
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.6.1
> Reporter: Gilles Sadowski
> Priority: Minor
> Labels: design
> Fix For: 4.0, 4.X
>
>
> Class {{SimplexTableau}} is package private and does not seem designed for
> inheritance, but it contains "protected" methods.
> There are several instance fields that should preferably be made "final" (for
> thread safety). It seems that to do this, some design changes are necessary
> (a.o. the relationship with {{SimplexSolver}} should be clarified).
>
> {{SimplexSolver}} also contains a protected method ({{solvePhase1}}) that is
> not documented for inheritance.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
