[ 
https://issues.apache.org/jira/browse/NUMBERS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162409#comment-17162409
 ] 

Gilles Sadowski commented on NUMBERS-148:
-----------------------------------------

bq. If you've seen the need somewhere

You showed the need in {{SimplexTableau}}.
Even if it's the sole place, it's one place too many, IMO because, from the 
perspective of someone trying to understand the solver, the scaling functions 
are just added noise.
It could as well be seen as the user's responsibility to "prepare" the inputs 
(i.e. be aware that scaling may be necessary in order to avoid spurious 
exceptions) before passing them to the solver.  The compromise might be to 
perform the scaling within the solver (as per your fix), but have all the gory 
details (of bit manipulations) encapsulated elsewhere (that is, in the JDK and 
"Commons Numbers").

bq. define things locally and only refactor when the need arises.

As a project gets bigger, and few people maintain it, it's unlikely that 
resources will be available when the need arises.  The "Commons Math" library 
is IMHO an sad example of this issue.

> Extract double exponent manipulation routines from commons-math to numbers
> --------------------------------------------------------------------------
>
>                 Key: NUMBERS-148
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-148
>             Project: Commons Numbers
>          Issue Type: Improvement
>          Components: core
>            Reporter: Mohammad Rezaei
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to