garydgregory commented on a change in pull request #93:
URL: https://github.com/apache/commons-vfs/pull/93#discussion_r465055550
##########
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileRandomAccessContent.java
##########
@@ -45,7 +45,7 @@
@Override
public int read() throws IOException {
try {
- return raf.readByte();
+ return raf.readByte() & 0xFF;
Review comment:
Let's avoid repeated use of a magic number. Please refactor into a
constant that's reused in the code and tests. Same for -1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
