geoffreyblake commented on a change in pull request #103:
URL: https://github.com/apache/commons-crypto/pull/103#discussion_r466522712
##########
File path: Makefile.common
##########
@@ -163,17 +163,17 @@ Linux-arm_COMMONS_CRYPTO_FLAGS:=
Linux-armhf_CC := $(CROSS_PREFIX)gcc
Linux-armhf_CXX := $(CROSS_PREFIX)g++
Linux-armhf_STRIP := $(CROSS_PREFIX)strip
-Linux-armhf_CFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
-Linux-armhf_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
+Linux-armhf_CFLAGS := -I"$(JAVA_HOME)/include"
-I/usr/include/i386-linux-gnu -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
+Linux-armhf_CXXFLAGS := -I"$(JAVA_HOME)/include"
-I/usr/include/i386-linux-gnu -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
Linux-armhf_LINKFLAGS := -shared -static-libgcc
Linux-armhf_LIBNAME := libcommons-crypto.so
Linux-armhf_COMMONS_CRYPTO_FLAGS:=
Linux-aarch64_CC := $(CROSS_PREFIX)gcc
Linux-aarch64_CXX := $(CROSS_PREFIX)g++
Linux-aarch64_STRIP := $(CROSS_PREFIX)strip
-Linux-aarch64_CXXFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include"
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror
-Linux-aarch64_CFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include"
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror
+Linux-aarch64_CXXFLAGS := -I"$(JAVA_HOME)/include"
-I/usr/include/i386-linux-gnu -O2 -fPIC -fvisibility=hidden -Wall -Werror
+Linux-aarch64_CFLAGS := -I"$(JAVA_HOME)/include"
-I/usr/include/i386-linux-gnu -O2 -fPIC -fvisibility=hidden -Wall -Werror
Review comment:
Some documentation in here may be required to explain why there's an
i368 architecture directory specified in the aarch64 compile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
