aremily commented on pull request #103: URL: https://github.com/apache/commons-crypto/pull/103#issuecomment-670028371
Let me add that to the list of things to look at. It may be something I forgot to go back and change. On Thu, Aug 6, 2020 at 12:07 PM Geoffrey Blake <[email protected]> wrote: > *@geoffreyblake* commented on this pull request. > ------------------------------ > > In Makefile.common > <https://github.com/apache/commons-crypto/pull/103#discussion_r466522712>: > > > Linux-armhf_LINKFLAGS := -shared -static-libgcc > Linux-armhf_LIBNAME := libcommons-crypto.so > Linux-armhf_COMMONS_CRYPTO_FLAGS:= > > Linux-aarch64_CC := $(CROSS_PREFIX)gcc > Linux-aarch64_CXX := $(CROSS_PREFIX)g++ > Linux-aarch64_STRIP := $(CROSS_PREFIX)strip > -Linux-aarch64_CXXFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror > -Linux-aarch64_CFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror > +Linux-aarch64_CXXFLAGS := -I"$(JAVA_HOME)/include" -I/usr/include/i386-linux-gnu -O2 -fPIC -fvisibility=hidden -Wall -Werror > +Linux-aarch64_CFLAGS := -I"$(JAVA_HOME)/include" -I/usr/include/i386-linux-gnu -O2 -fPIC -fvisibility=hidden -Wall -Werror > > Some documentation in here may be required to explain why there's an i368 > architecture directory specified in the aarch64 compile. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-crypto/pull/103#pullrequestreview-462663495>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABUDY7RWHSFS2GMUCLM6PTDR7LIKTANCNFSM4PSSOBEQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
