Hippo commented on a change in pull request #58:
URL: https://github.com/apache/commons-bcel/pull/58#discussion_r468839745
##########
File path: src/main/java/org/apache/bcel/classfile/ClassParser.java
##########
@@ -303,5 +304,6 @@ private void readMethods() throws IOException,
ClassFormatException {
private void readVersion() throws IOException, ClassFormatException {
minor = dataInputStream.readUnsignedShort();
major = dataInputStream.readUnsignedShort();
+ isOak = major < Const.MAJOR_1_1 || (major == Const.MAJOR_1_1 && minor
< 3);
Review comment:
> >
[OakFile.java.zip](https://github.com/apache/commons-bcel/files/5054556/OakFile.java.zip)
> > There is no license, it's practically a hello world program.
>
> Hi @Hippo
> I'll should be able to take a look this weekend to see if a cleaner
approach can be devised. In the meantime, please provide the source .java and
instructions on how you created the class file if it is out of the ordinary
Java tooling we are all used to. Is there an Oak/Java 1.0 compiler you used we
can download to create additional files?
No I don't have an oak compiler, but you can emulate one by transforming a
class file and changing its version to a proper oak version and halfing the
correct data types in the code attribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
