Hippo commented on a change in pull request #58:
URL: https://github.com/apache/commons-bcel/pull/58#discussion_r468840192
##########
File path: src/main/java/org/apache/bcel/classfile/ClassParser.java
##########
@@ -303,5 +304,6 @@ private void readMethods() throws IOException,
ClassFormatException {
private void readVersion() throws IOException, ClassFormatException {
minor = dataInputStream.readUnsignedShort();
major = dataInputStream.readUnsignedShort();
+ isOak = major < Const.MAJOR_1_1 || (major == Const.MAJOR_1_1 && minor
< 3);
Review comment:
> Should the check be `minor <= 3` instead? See notes.
> Are you saying that 45.2 is not compatible with 45.3?
No it should be `minor < 3` take a look at the jvm's class parser
https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/4b69552faa8de8f7de5bed1c95c12c025702b8ee/hotspot/src/share/vm/classfile/classFileParser.cpp#L2137
Also I check `major < Const.MAJOR_1_1` just in-case the major version is
less than 45, which shouldn't happen, but it's there just in-case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
