[ 
https://issues.apache.org/jira/browse/IMAGING-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180561#comment-17180561
 ] 

Bruno P. Kinoshita commented on IMAGING-264:
--------------------------------------------

PR created [~rampravin] : [https://github.com/apache/commons-imaging/pull/94]

Thanks for reporting the issue!

> BMP Parser physicalWidthDpi and physicalHeightDpi truncated before rounding 
> off.
> --------------------------------------------------------------------------------
>
>                 Key: IMAGING-264
>                 URL: https://issues.apache.org/jira/browse/IMAGING-264
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: BMP
>    Affects Versions: 1.0-alpha2
>            Reporter: Ram
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 1.0-alpha3
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In BMPImageParser class, the values are typecasted to int before rounding off 
> so output varies(other parsers has this logic correct).
> int physicalWidthDpi = (int)((double)bhi.hResolution * 0.0254D);
> int physicalHeightDpi = (int)((double)bhi.vResolution * 0.0254D);
>  
> Expected :
> int physicalWidthDpi = (int)*Math.round*((double)bhi.hResolution * 0.0254D);
> int physicalHeightDpi = (int)*Math.round*((double)bhi.vResolution * 0.0254D);



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to