[ 
https://issues.apache.org/jira/browse/IMAGING-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180957#comment-17180957
 ] 

Bruno P. Kinoshita commented on IMAGING-264:
--------------------------------------------

Don't mention it [~rampravin] . You did all the hard work of reporting the 
issue, and you even gave the solution :) let us know if you find any other 
issues. Aiming at releasing alpha3 somewhere around the end of the year.

> BMP Parser physicalWidthDpi and physicalHeightDpi truncated before rounding 
> off.
> --------------------------------------------------------------------------------
>
>                 Key: IMAGING-264
>                 URL: https://issues.apache.org/jira/browse/IMAGING-264
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: BMP
>    Affects Versions: 1.0-alpha2
>            Reporter: Ram
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 1.0-alpha3
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In BMPImageParser class, the values are typecasted to int before rounding off 
> so output varies(other parsers has this logic correct).
> int physicalWidthDpi = (int)((double)bhi.hResolution * 0.0254D);
> int physicalHeightDpi = (int)((double)bhi.vResolution * 0.0254D);
>  
> Expected :
> int physicalWidthDpi = (int)*Math.round*((double)bhi.hResolution * 0.0254D);
> int physicalHeightDpi = (int)*Math.round*((double)bhi.vResolution * 0.0254D);



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to