[ 
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183970#comment-17183970
 ] 

Jin Xu edited comment on LANG-1601 at 8/25/20, 12:01 PM:
---------------------------------------------------------

[~aherbert]

Yep, I know why we do this there. Just asking about whether we should handle 
this also in numbers.
I've started a "porting" try, means port every public function interfaces in 
commons-lang's Fraction into commons-numbers's Fractions.
(Though the designing differences I mentioned above might cause some logic/test 
changes, but we can remain the public interfaces).

And next step I will see through all tests in original commons-lang, and 
delete/renew ones who now not quite correct with the logic in commons-number.

Then we can discuss about deprecate commons-lang's Fraction.



was (Author: xenoamess):
[~aherbert]

Yep, I know why we do this there. Just asking about whether we should handle 
this also in numbers.
I've started a "porting" try, means port every public functions in 
commons-lang's Fraction into commons-numbers's Fractions.
(Though the designing differences I mentioned above might cause some logic/test 
changes, but we can remain the public interfaces).

And next step I will see through all tests in original commons-lang, and 
delete/renew ones who now not quite correct with the logic in commons-number.

Then we can discuss about deprecate commons-lang's Fraction.


> refine performance of Fraction.pow
> ----------------------------------
>
>                 Key: LANG-1601
>                 URL: https://issues.apache.org/jira/browse/LANG-1601
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.math.*
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to