[
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184127#comment-17184127
]
Jin Xu edited comment on LANG-1601 at 8/25/20, 3:28 PM:
--------------------------------------------------------
[~aherbert]
Hi.
You are correct in general.
You can see what I wanna do in [NUMBERS-149] and
https://github.com/apache/commons-numbers/pull/82
In short, this pr contains more things than you said are:
1. modified tests from commons-lang.
2. cached toString and hashCode property, to avoid calculate twice.
3. some changes in function pow (which I think good).
The reduce() method is not required, and become meaningless, but other than
deleting it, I found a new usage to give it. You can see more details in that
pr.
was (Author: xenoamess):
[~aherbert]
Hi.
You are correct in general.
You can see what I wanna do in [NUMBERS-149] and
https://github.com/apache/commons-numbers/pull/82
> refine performance of Fraction.pow
> ----------------------------------
>
> Key: LANG-1601
> URL: https://issues.apache.org/jira/browse/LANG-1601
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.math.*
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
