welcor commented on a change in pull request #19:
URL: https://github.com/apache/commons-codec/pull/19#discussion_r483167389



##########
File path: src/test/java/org/apache/commons/codec/binary/Base64TestData.java
##########
@@ -30,7 +30,7 @@
  */
 public class Base64TestData {
 
-    public static final String CODEC_101_MULTIPLE_OF_3 = "123";
+    public static final String CODEC_101_MULTIPLE_OF_3 = "124";

Review comment:
       I dug in and found the reason: 
https://issues.apache.org/jira/browse/CODEC-134?focusedCommentId=13222167&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13222167
 
   It should really be renamed to "three digit valid base64 value" or someting. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to