welcor commented on a change in pull request #19:
URL: https://github.com/apache/commons-codec/pull/19#discussion_r483178099
##########
File path: src/test/java/org/apache/commons/codec/binary/Base64TestData.java
##########
@@ -30,7 +30,7 @@
*/
public class Base64TestData {
- public static final String CODEC_101_MULTIPLE_OF_3 = "123";
+ public static final String CODEC_101_MULTIPLE_OF_3 = "124";
Review comment:
Yes, I found the strangely named variable when going through the changes
in 1.15 (because 1.14 broke our builds). It just struck me that 123 is indeed a
multiple of 3, but 124 isn't. Later on, I found out that it probably was meant
as "valid b64 of length 3". Which works for 124 but not 123. So it's a poorly
named variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
