ifly6 edited a comment on pull request #190: URL: https://github.com/apache/commons-text/pull/190#issuecomment-743763305
> This PR is missing unit tests. I don't know anything about how to build the project locally ~~or how to fix the unit tests.~~ Looking at the logs for the build, it seems that there's some counter which tallies `new HashMap<>()` calls and `initialMap.put` calls. I don't know why the test is set up this way, but I think it implies that the way the CP1252 map variable is set up, which uses `new HashMap<>(ISO8859_1_ESCAPE)` will always raise an error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
