ifly6 commented on a change in pull request #190:
URL: https://github.com/apache/commons-text/pull/190#discussion_r541787388
##########
File path: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
##########
@@ -49,12 +49,14 @@
private static final String FOO = "foo";
private static final String[][] HTML_ESCAPES = {
+ // message, expected, original
{"no escaping", "plain text", "plain text"},
{"no escaping", "plain text", "plain text"},
{"empty string", "", ""},
{"null", null, null},
{"ampersand", "bread & butter", "bread & butter"},
{"quotes", ""bread" & butter", "\"bread\" & butter"},
+ {"smart quotes", "“bread and circuses”", "\u201Cbread
and circuses\u201d"},
Review comment:
I tested a single value because the tests seem to test only a few
values; adding an exhaustive number of tests seems mostly just to reproduce the
existing map.
That said, thinking about how the library handles numeric escapes, I don't
think it solves the initial problem that led me towards creating this pull
request – translating something like `“` to `“` or `‰` to `‰` so I've
closed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
