[
https://issues.apache.org/jira/browse/IMAGING-273?focusedWorklogId=524102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524102
]
ASF GitHub Bot logged work on IMAGING-273:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/20 20:42
Start Date: 14/Dec/20 20:42
Worklog Time Spent: 10m
Work Description: arturobernalg edited a comment on pull request #112:
URL: https://github.com/apache/commons-imaging/pull/112#issuecomment-744663682
Hi @kinow
The idea of declaring variables final within methods is to prevent them from
being modified within the scope by mistake. In this way, we force everyone who
wants to work on the method not to modify it. not reuse var. approach.
Pls let me know if you prefer other PR only with the change of the javadoc
while you complete the review.
I'm glad to know that your holidays are coming soon :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524102)
Time Spent: 40m (was: 0.5h)
> Minor improvement
> -----------------
>
> Key: IMAGING-273
> URL: https://issues.apache.org/jira/browse/IMAGING-273
> Project: Commons Imaging
> Issue Type: Improvement
> Reporter: Arturo Bernal
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Minor improvement:
> * extra computations by getting the string size only once.
> * remove unused imports
> * add final String
> * add final method and var
> * fix javaDoc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
