[
https://issues.apache.org/jira/browse/IMAGING-273?focusedWorklogId=526423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-526423
]
ASF GitHub Bot logged work on IMAGING-273:
------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/20 02:28
Start Date: 20/Dec/20 02:28
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #112:
URL: https://github.com/apache/commons-imaging/pull/112#discussion_r546309531
##########
File path:
src/main/java/org/apache/commons/imaging/common/itu_t4/T4AndT6Compression.java
##########
@@ -139,8 +139,8 @@ private static void compress1DLine(final
BitInputStreamFlexible inputStream,
public static byte[] decompressModifiedHuffman(final byte[] compressed,
final int width, final int height) throws ImageReadException {
try (ByteArrayInputStream baos = new ByteArrayInputStream(compressed);
- BitInputStreamFlexible inputStream = new
BitInputStreamFlexible(baos);
- BitArrayOutputStream outputStream = new
BitArrayOutputStream()) {
Review comment:
:+1:
##########
File path:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java
##########
@@ -59,8 +59,8 @@
* Block types (or Image Resource IDs) that are not recommended to be
* interpreted when libraries process Photoshop IPTC metadata.
*
- * @see https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/
- * @see https://issues.apache.org/jira/browse/IMAGING-246
+ * @see <a
href="https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/";> Adobe
Photoshop File Formats Specification</a>
+ * @see <a
href="https://issues.apache.org/jira/browse/IMAGING-246>IMAGING-246</a>
Review comment:
Merged in your other PR :+1: (thanks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 526423)
Time Spent: 50m (was: 40m)
> Minor improvement
> -----------------
>
> Key: IMAGING-273
> URL: https://issues.apache.org/jira/browse/IMAGING-273
> Project: Commons Imaging
> Issue Type: Improvement
> Reporter: Arturo Bernal
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Minor improvement:
> * extra computations by getting the string size only once.
> * remove unused imports
> * add final String
> * add final method and var
> * fix javaDoc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
