Brixomatic commented on a change in pull request #114:
URL: https://github.com/apache/commons-imaging/pull/114#discussion_r548983923
##########
File path:
src/test/java/org/apache/commons/imaging/color/ColorConversionsTest.java
##########
@@ -39,7 +40,7 @@ public void testRGBtoCMYK() {
Debug.debug("cmyk_cmy: " + cmyk_cmy);
Debug.debug("cmyk_cmy_rgb: " + cmyk_cmy_rgb + " (" +
Integer.toHexString(cmyk_cmy_rgb) + ")");
- assertEquals((0xffffff & cmyk_cmy_rgb), (0xffffff & rgb));
+ assertEquals(toHexString(0xffffff & rgb), toHexString(0xffffff &
cmyk_cmy_rgb));
Review comment:
"expected" and "actual" values where in the wrong order. Also, comparing
the hex strings is much more comprehensible in test failure messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
