garydgregory commented on a change in pull request #91:
URL:
https://github.com/apache/commons-configuration/pull/91#discussion_r551023253
##########
File path:
src/main/java/org/apache/commons/configuration2/interpol/ConstantLookup.java
##########
@@ -53,7 +53,7 @@
private static final char FIELD_SEPRATOR = '.';
/** An internally used cache for already retrieved values. */
- private static Map<String, Object> constantCache = new HashMap<>();
+ private static final Map<String, Object> constantCache = new HashMap<>();
Review comment:
@arturobernalg
Again, static finals are in UPPER CASE by convention, so `constantCache`
becomes `CONSTANT_CACHE`. PLEASE, review the whole PR before submission.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
